Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve fee rendering in approval dialogue #85

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Jul 2, 2024

references penumbra-zone/web#1311 and penumbra-zone/web#1358. One of the side-effects of the migration is that these same changes should be propagated to the web ui package for minifront to consume.

  • fees don’t have metadata, so modifies swap claim fees to display the proper amounts and denoms (rather than incorrectly hardcoding upenumbra for all trades)
  • fixes pill size in transaction approval dialogue

before

Screenshot 2024-07-04 at 12 56 35 PM

after

Screenshot 2024-07-04 at 12 55 42 PM

@TalDerei TalDerei self-assigned this Jul 2, 2024
Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 259a97d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TalDerei TalDerei marked this pull request as draft July 2, 2024 23:15
@TalDerei TalDerei marked this pull request as ready for review July 4, 2024 19:57
@TalDerei TalDerei requested a review from a team July 4, 2024 19:57
@TalDerei TalDerei changed the title don't hardcode fees improve fee rendering Jul 4, 2024
@TalDerei TalDerei changed the title improve fee rendering improve fee rendering in approval dialogue Jul 4, 2024
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments in penumbra-zone/web#1419

@TalDerei TalDerei merged commit 0502586 into main Jul 5, 2024
3 checks passed
@TalDerei TalDerei deleted the hardcoding-fees branch July 5, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants