Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Preserve complex props across connectedCallback calls #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Preserve complex props across connectedCallback calls #71

wants to merge 1 commit into from

Commits on Apr 11, 2022

  1. Preserve props set after vdom creation 

    This fixes the issue when the complex prop was not preserved
across connectectedCallback calls.

When complex prop is set as first property then everything
worked as expected. But when complex prop is set after other prop
then it was not stored into this._props and that caused missing it
in the implicit connectedCallback call. Because in connectedCallback
we set props from attributes (simple props) and from this._props.
    @xPapay
    xPapay committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    ee1e6b3 View commit details
    Browse the repository at this point in the history