Add support for shadow DOM closed mode

[stevenle]

Fixes #74

[marvinhagemeister]

Looks good! Thanks for making a PR 👍 Is it possible to add a test case for this so that we don't regress on this in the future?

[stevenle]

I added two tests (one for {mode: 'open'} and one for {mode: 'closed'}. Would appreciate another look to make sure I'm following the correct patterns for this project.

(Note: I needed to update puppeteer in order for it to work on my Macbook with Apple Silicon. npm install wasn't working for me, so I used yarn and so the package-lock.json file wasn't updated.) Edit: Ignore this, I realized npm test:browsers worked without the puppeteer dependency.

[marvinhagemeister]

Awesome, thanks a bunch for adding tests 👍

[stevenle]

Thanks for the review! What's the next step from here? I assume you'll handle the merge and the publish to npm?

[AGrabovajFitA]

Hi @marvinhagemeister , what's the next step here. Can we get this out?

[leifriksheim]

Hi, any updates on this PR?
I would love for this to get merged as we wouldn't have to keep our own fork of this project. 🙏

[MattCCC]

Test CI still fails it seems

[bhollis]

@marvinhagemeister if you update this branch it may pass now.

[bhollis]

Nice, the tests are passing!

[janbiasi]

Seems like this is not included in the latest version, when can we expect this to get released?

[HowieG]

Also need this change and wondering when it will be released!

[HowieG]

@janbiasi dang I just realized the last publish to npm was in 2020 😲 . Haven't encountered this before do we just clone the repo then?

[HowieG]

@janbiasi seems we can change our package.json to grab from the repo directly

{
"dependencies": {
"preact-custom-element": "https://github.com/preactjs/preact-custom-element.git"
}
}

[janbiasi]

seems we can change our package.json to grab from the repo directly

@HowieG Well yes, that works as a workaround at least 😄
But I'm really questioning why this feature wasn't released via NPM.
Maybe @marvinhagemeister can tell us more details about the official release.

[HowieG]

@janbiasi yooo we did it!! #84 hahaha

[HowieG]

@janbiasi FYI there wasn't a subsequent change to the types for this change. It's simple but need to go through DefinitelyTyped's kinda thorough PR process. I'm just ignoring for now.

DefinitelyTyped/DefinitelyTyped@1709f05

[janbiasi]

@HowieG Yea! 😎 Thanks for the support on this one. I think I should have time to go through the definitely typed PR process pretty soon but as you said, it also works without them - I'll keep you updated :)

[rschristian]

Alternatively, I think we're happy to add the types here. I don't think there's any real need to use DefinitelyTyped

[janbiasi]

Alternatively, I think we're happy to add the types here. I don't think there's any real need to use DefinitelyTyped

Thanks for the hint @rschristian, I just opened a PR #85 for this.

cc @HowieG