-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple suspense renderer 2024 #333
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d0a7b1a
Simple Suspense renderer
lemonmade 03b90eb
Merge branch 'main' into simple-suspense-renderer
JoviDeCroock 5fbe601
update simple suspense rendere
JoviDeCroock 9756cc8
add a possible promise string as the return value
JoviDeCroock 6c58b5e
Update test/compat/async.test.js
JoviDeCroock 5f7559d
Create pink-gifts-kneel.md
JoviDeCroock 80c0a70
non breaking
JoviDeCroock ad7b662
Update async.test.js
JoviDeCroock c57b230
fixing nested Suspense boundaries (#334)
dios-david cf81587
fixing multiple suspended child components (#335)
dios-david File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"preact-render-to-string": minor | ||
--- | ||
|
||
Allow prepass like behavior where a Promise | ||
will be awaited and then continued, this is done with | ||
the new `renderToStringAsync` export |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,17 @@ | ||
import { VNode } from 'preact'; | ||
|
||
export default function renderToString<P = {}>(vnode: VNode<P>, context?: any): string; | ||
export default function renderToString<P = {}>( | ||
vnode: VNode<P>, | ||
context?: any | ||
): string; | ||
|
||
export function render<P = {}>(vnode: VNode<P>, context?: any): string; | ||
export function renderToString<P = {}>(vnode: VNode<P>, context?: any): string; | ||
export function renderToStaticMarkup<P = {}>(vnode: VNode<P>, context?: any): string; | ||
export function renderToStringAsync<P = {}>( | ||
vnode: VNode<P>, | ||
context?: any | ||
): string | Promise<string>; | ||
export function renderToStaticMarkup<P = {}>( | ||
vnode: VNode<P>, | ||
context?: any | ||
): string; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only just noticed, this is a breaking change for all preact-iso users... do we want to downgrade this to a warning message instead of throwing an error, or just accept the breaking change in a minor?