Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Customizing Diff Logic (via new shouldUpdate method) #218

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sghoweri
Copy link

This PR provides a way to (optionally) customize how incoming values are evaluated (ie. has this value actually changed) via the new shouldUpdate method; a very similar use case to #103 that I also ran into!

Also adds a new test to demonstrate before vs after behavior + a tiny usage example.

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

⚠️ No Changeset found

Latest commit: 5067445

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 5067445
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6331f2e3c35d9e000969dcf8
😎 Deploy Preview https://deploy-preview-218--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@XantreDev
Copy link
Contributor

Changing prototype is affecting all signals. I thinks it's not a best way to provide custom equality checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants