Bundle Rollup defs into TypeScript definition before publishing #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation here is super ridiculous, I know.
I tried all of the
d.ts
bundlers I could find, and none of them were able to handle ambient declarations within types to be bundled. Our types have them, but some of the types we depend on do as well (aconnect
middleware that is a dependency of Polka's types).Originally I had built this to inline 100% of our type deps, but I don't think that approach can be made to function correctly. Instead, since we already scaffold projects with Automatic Type Acquisition, I've limited the inlining to only module-provided definitions (no
@types/*
) - effectively, onlyrollup
.Since it's just rollup, maybe a better solution here would be to have a build script inline Rollup's
d.ts
(which is already in node_modules and has no dependencies).