-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prerender deletes <html> attributes #651
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0b1cb6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -44,178 +42,3 @@ export function prerender({ cwd = '.', out = '.cache', publicPath }) { | |||
w.once('exit', resolve); | |||
}); | |||
} | |||
|
|||
async function workerCode({ cwd, out, publicPath }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff looks a lot larger due to moving this function into a separate file.
Size Change: -1.05 kB (0%) Total Size: 779 kB
ℹ️ View Unchanged
|
if (!hasTitle) { | ||
// TODO: TS types of posthtml seem to be wrong | ||
// @ts-ignore | ||
node.content?.unshift({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks in Node 12
node.content?.unshift({ | |
node.content && node.content.unshift({ |
Hello :) |
Fixes #593