Vdo.ai Bid Adapter : update to prebid version 9 #12284
Conversation
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
it appears you have a lot of duplication with the onetag adapter. Please move the visibility code in both adapters into a common utility library, probably the precentInView one |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
hi @patmmccann We have removed the visibility and page timing functions since they are not required anymore on our end. LMK if anything else needs to be done. |
|
Hi @patmmccann I’d like to follow up on the status of the merge request. Is there anything I can assist with to help expedite the process? |
ChrisHuie
changed the title
modules/vdoaiBidAdapter.js
Outdated
| if (validBidRequests && validBidRequests.length !== 0 && validBidRequests[0].userIdAsEids) { | ||
| payload.userId = validBidRequests[0].userIdAsEids; | ||
| } | ||
| if (config.getConfig('coppa') === true) { |
There was a problem hiding this comment.
Can you please access coppa from bidderRequest.ortb2.regs.coppa instead of config
There was a problem hiding this comment.
Hey @ChrisHuie , thanks for the review. we have made the necessary changes. Is there anything else I can assist with?
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Hi @ChrisHuie , I wanted to follow up on the merge request. If there's anything I can do to help speed up the process, please let me know. Thanks! |
1 similar comment
|
Hi @ChrisHuie , I wanted to follow up on the merge request. If there's anything I can do to help speed up the process, please let me know. Thanks! |
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
|
Hi @ChrisHuie @ncolletti , I wanted to follow up on the merge request. If there's anything I can do to help speed up the process, please let me know. Thanks! |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Bid request parameters updated and logical implementations.
Document updated: prebid/prebid.github.io#5690