-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New BidAdapter:InMobi #12449
base: master
Are you sure you want to change the base?
New BidAdapter:InMobi #12449
Conversation
Tread carefully! This PR adds 178 linter errors (possibly disabled through directives):
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
return loggingPercentage != 0; | ||
} | ||
|
||
function report(type, data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would benefit from fetch keepalive, used a few other places in the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @patmmccann , addressed the comment.
Thank You!!
if (!data) { | ||
return; | ||
} | ||
if (['onBidWon', 'onAdRenderSucceeded', 'onSetTargeting'].includes(type) && !isReportingAllowed(data.loggingPercentage)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is loggingPercentage getting set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @patmmccann ,loggingPercentage
will be set by our backend in response.seatbid.bid[i].ext.loggingPercentage
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other