Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BidAdapter:InMobi #12449

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yuva-inmobi-1
Copy link

@yuva-inmobi-1 yuva-inmobi-1 commented Nov 15, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Banner Ad units

    var adUnits = [{
            code: 'div-gpt-ad-1460505748561-0',
            mediaTypes: {
                banner: {
                    sizes: [[300, 250]],
                }
            },

            bids: [{
                bidder: 'inmobi',
                params: {
                    plc: '1719108420057' // Mandatory
                }
            }]

    }];

Video  Ad units
    var adUnits = [{
            code: 'div-gpt-ad-1460505748561-0',
            mediaTypes: {
                video: {
                    playerSize : [300,250],
                    mimes :  ["video/x-ms-wmv", "video/mp4"],
                    minduration : 0,
                    maxduration: 30,
                    protocols : [1,2],
                    api: [1, 2, 4, 6],
                    protocols: [3, 4, 7, 8, 10],
                    placement: 1,
                    plcmt: 1
                }
            },

            // Replace this object to test a new Adapter!
            bids: [{
                bidder: 'inmobi',
                params: {
                    plc: '1443164204446401' //Mandatory
                }
            }]
    }];

Native ad units

    var adUnits = [{
            code: 'div-gpt-ad-1460505748561-0',
            mediaTypes: {
                native: {
                        type: 'image'
                }
            },

            bids: [{
                bidder: 'inmobi',
                params: {
                    plc: '10000033152',
                    bidfloor: 0.9
                }
            }]
    }];

Copy link

Tread carefully! This PR adds 178 linter errors (possibly disabled through directives):

  • modules/inmobiBidAdapter.js (+178 errors)

Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/inmobiBidAdapter.js (+1 error)

return loggingPercentage != 0;
}

function report(type, data) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would benefit from fetch keepalive, used a few other places in the project

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patmmccann , addressed the comment.
Thank You!!

if (!data) {
return;
}
if (['onBidWon', 'onAdRenderSucceeded', 'onSetTargeting'].includes(type) && !isReportingAllowed(data.loggingPercentage)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is loggingPercentage getting set?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patmmccann ,loggingPercentage will be set by our backend in response.seatbid.bid[i].ext.loggingPercentage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants