Module storage #132
Merged
Module storage #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +50,7 @@ public class PostCacheHandler extends CacheHandler { | |||
|
|
|||
| private static final String UUID_KEY = "uuid"; | |||
| private static final String SECONDARY_CACHE_KEY = "secondaryCache"; | |||
| private static final String MODULE_STORAGE_PREFIX = "module."; | |||
There was a problem hiding this comment.
so saving into the module storage is restricted here by the module prefix, but at the same time there isn't any guarantee that the module storage saves everything with that prefix (it could be any), so what's the matter of this check? Shouldn't we save everything into the module storage with that prefix to guarantee this check makes sense?
Am I missing something?
src/main/java/org/prebid/cache/handlers/cache/PostCacheHandler.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
previously approved these changes
Jul 8, 2024
SerhiiNahornyi
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.