Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate combined Javadoc documentation #791

Merged
merged 22 commits into from
Oct 3, 2024
Merged

Generate combined Javadoc documentation #791

merged 22 commits into from
Oct 3, 2024

Conversation

ValentinPostindustria
Copy link
Collaborator

@ValentinPostindustria ValentinPostindustria commented Aug 6, 2024 •
edited by YuriyVelichkoPI
Loading

@ValentinPostindustria ValentinPostindustria self-assigned this Aug 6, 2024
ValentinPostindustria and others added 20 commits August 6, 2024 10:29
@YuriyVelichkoPI YuriyVelichkoPI marked this pull request as ready for review September 24, 2024 10:00
bretg
bretg requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing progress. I'd imagine there are probably tweaks we'll want to make to the actual docs, but my only substantive comment is to consider making the github action a little more robust.

.github/workflows/upload-docs.yml Outdated Show resolved Hide resolved
.github/workflows/upload-docs.yml Show resolved Hide resolved
bretg
bretg approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the workflow more robust. Note that my review is quite limited. @YuriyVelichkoPI will need to sign off with a more robust review.

@YuriyVelichkoPI YuriyVelichkoPI merged commit a115219 into master Oct 3, 2024
5 checks passed
@YuriyVelichkoPI YuriyVelichkoPI deleted the feature/documentation branch October 3, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

@YuriyVelichkoPI YuriyVelichkoPI Awaiting requested review from YuriyVelichkoPI

Assignees

@ValentinPostindustria ValentinPostindustria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValentinPostindustria @bretg @YuriyVelichkoPI