-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPM, bidder params, flag header in GreenbidsAnalyticsReporter #3253
Closed
EvgeniiMunin
wants to merge
54
commits into
prebid:master
from
EvgeniiMunin:greenbids-add-params-analytics2
Closed
Add CPM, bidder params, flag header in GreenbidsAnalyticsReporter #3253
EvgeniiMunin
wants to merge
54
commits into
prebid:master
from
EvgeniiMunin:greenbids-add-params-analytics2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We want to add the following info into analytics payload
Bid
, currency fromBidResponse
for each bidderBidRequest
extensionimp[].ext.prebid.bidder
The PR is based on #3096 and I will rebase it after the first one is merged
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 Test plan
Have added
givenPrebidNode
with the bidder params intoGreenbidsAnalyticsReporterTest
so we can test the new payload.🏎 Quality check