Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Fields to Eid Object #3470

Merged
merged 3 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions src/main/java/com/iab/openrtb/request/Eid.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,19 @@

import java.util.List;

/**
* Extended identifiers support in the OpenRTB specification allows buyers
* to use audience data in real-time bidding. This object can contain one
* or more {@link Uid}s from a single source or a technology provider. The
* exchange should ensure that business agreements allow for the sending
* of this data.
*/
@Value
@Builder(toBuilder = true)
public class Eid {

/**
* Source or technology provider responsible for the set of included IDs. Expressed as a top-level domain.
*/
String source;

/**
* Array of extended ID {@link Uid} objects from the given source.
* Refer to 3.2.28 Extended Identifier UIDs
*/
List<Uid> uids;

/**
* Placeholder for vendor specific extensions to this object
*/
String inserter;

String matcher;

Integer mm;

ObjectNode ext;
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.prebid.server.functional.model.request.auction

import com.fasterxml.jackson.annotation.JsonProperty
import groovy.transform.EqualsAndHashCode
import groovy.transform.ToString
import org.prebid.server.functional.util.PBSUtils
Expand All @@ -10,11 +11,18 @@ class Eid {

String source
List<Uid> uids
String inserter
String matcher
@JsonProperty("mm")
Integer matchMethod

static Eid getDefaultEid(String source = PBSUtils.randomString) {
new Eid().tap {
it.source = source
it.uids = [Uid.defaultUid]
it.inserter = PBSUtils.randomString
it.matcher = PBSUtils.randomString
it.matchMethod = PBSUtils.randomNumber
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class OrtbConverterSpec extends BaseSpec {
}
}

def "PBS should move eids to o user.ext.eids when adapter doesn't support ortb 2.6"() {
def "PBS should move eids to user.ext.eids when adapter doesn't support ortb 2.6"() {
given: "Default bid request with user.eids"
def defaultEids = [Eid.defaultEid]
def bidRequest = BidRequest.defaultBidRequest.tap {
Expand Down