Fixes panic with cleaning blank IPs (#676)

prebid · Sep 12, 2018 · 0b49720 · 0b49720
1 parent b7f4f12
commit 0b49720
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/exchange/gdpr.go b/exchange/gdpr.go
@@ -74,12 +74,18 @@ func cleanPI(bidRequest *openrtb.BidRequest) {
 // Zero the last byte of an IP address
 func cleanIP(fullIP string) string {
 	i := strings.LastIndex(fullIP, ".")
+	if i == -1 {
+		return ""
+	}
 	return fullIP[0:i] + ".000"
 }
 
 // Zero the last two bytes of an IPv6 address
 func cleanIPv6(fullIP string) string {
 	i := strings.LastIndex(fullIP, ":")
+	if i == -1 {
+		return ""
+	}
 	return fullIP[0:i] + ":0000"
 }
 

diff --git a/exchange/gdpr_test.go b/exchange/gdpr_test.go
@@ -92,3 +92,11 @@ func assertStringEmpty(t *testing.T, str string) {
 		t.Errorf("Expected an empty string, got %s", str)
 	}
 }
+
+func TestBadIPs(t *testing.T) {
+	assertStringEmpty(t, cleanIP("not an IP"))
+	assertStringEmpty(t, cleanIP(""))
+	assertStringEmpty(t, cleanIP("36278042"))
+	assertStringEmpty(t, cleanIPv6("not an IP"))
+	assertStringEmpty(t, cleanIPv6(""))
+}