Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Kueez #4038

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New Adapter: Kueez #4038

wants to merge 4 commits into from

Conversation

saar120
Copy link
Contributor

@saar120 saar120 commented Nov 5, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, bf7ab42

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:30:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:80:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:123:	extractCid		71.4%
total:									(statements)		84.0%

@SyntaxNode SyntaxNode changed the title Kueez RTB adapter New Adapter: Kueez Nov 5, 2024
przemkaczmarek
przemkaczmarek reviewed Nov 14, 2024
View reviewed changes
static/bidder-info/kueezrtb.yaml
@@ -0,0 +1,20 @@
endpoint: "https://prebidsrvr.kueezrtb.com/openrtb/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint doesnt work
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemkaczmarek
You need to add the cId to the request

prebid-server/adapters/kueezrtb/kueezrtb.go

Lines 54 to 62 in bf7ab42

requestData := &adapters.RequestData{
Method: "POST",
Uri: fmt.Sprintf("%s%s", a.endpoint, url.QueryEscape(cId)),
Body: requestJSON,
Headers: headers,
ImpIDs: []string{imp.ID},
}
requests = append(requests, requestData)

CleanShot 2024-11-19 at 11 51 03

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@przemkaczmarek
Can we approve please?

Copy link
Collaborator

@przemkaczmarek przemkaczmarek Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint works
image

przemkaczmarek
przemkaczmarek reviewed Nov 14, 2024
View reviewed changes
static/bidder-info/kueezrtb.yaml
userSync:
iframe:
url: https://sync.kueezrtb.com/api/user/html/62ce79e7dd15099534ae5e04?pbs=true&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}
userMacro: ${userId}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works
image

@przemkaczmarek przemkaczmarek self-assigned this Nov 25, 2024
przemkaczmarek
przemkaczmarek reviewed Nov 25, 2024
View reviewed changes
adapters/kueezrtb/params_test.go Outdated
}

var invalidParams = []string{
`{"cId": 3898334}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happend if You add:
var invalidParams = []string{
{},
{"cId": 123},
{"cId": true},
{"cId": null},
{"cId": ""},
{"cId": " "},
{"cId": "cid_with_invalid_chars!@#"},
{"cId": "valid_cid", "extra_field": "unexpected"},
{"cId": "a_very_long_connection_id_exceeding_the_maximum_allowed_length_..."},
[],
["cId"],
"string_value",
42,
true,
{"cId": "valid_cid",
{"cId":},
{"cid": "valid_cid"},
}
please add more invalidParams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more..

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b76086d

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:30:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:68:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:111:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:124:	getMediaTypeForBid	100.0%
total:									(statements)		84.0%

@bsardo
Copy link
Collaborator

bsardo commented Nov 26, 2024

Hi @saar120, we noticed that your adapter is basically the same as the Vidazoo adapter. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

@saar120
Copy link
Contributor Author

saar120 commented Nov 26, 2024

Hey @bsardo
We are providing the adapter and the server as a white label solution.
KueezRtb and Vidazoo are different entities and should not share the same adapter.
For now this solution does not fit our needs.

@assa-kariv
Copy link

@przemkaczmarek are we waiting for an additional approval? we would really appreciate if it could be included in the following release

@przemkaczmarek
Copy link
Collaborator

@assa-kariv In our policy, we require two approvals.

@przemkaczmarek przemkaczmarek requested a review from bsardo December 4, 2024 13:38
@assa-kariv
Copy link

@przemkaczmarek yeah I am aware of that thanks for tagging another approver

@saar120
Copy link
Contributor Author

saar120 commented Dec 15, 2024 •
edited
Loading

@bsardo
Can you please help with a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assa-kariv assa-kariv assa-kariv left review comments

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

@bsardo bsardo Awaiting requested review from bsardo

At least 2 approving reviews are required to merge this pull request.

Assignees

@bsardo bsardo

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saar120 @bsardo @assa-kariv @przemkaczmarek