New Adapter: AdUp Tech #4076
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| package aduptech | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "net/http" | ||
| "strings" | ||
|
|
||
| "github.com/prebid/openrtb/v20/openrtb2" | ||
| "github.com/prebid/prebid-server/v3/adapters" | ||
| "github.com/prebid/prebid-server/v3/config" | ||
| "github.com/prebid/prebid-server/v3/currency" | ||
| "github.com/prebid/prebid-server/v3/errortypes" | ||
| "github.com/prebid/prebid-server/v3/openrtb_ext" | ||
| "github.com/prebid/prebid-server/v3/util/jsonutil" | ||
| ) | ||
|
|
||
| type adapter struct { | ||
| endpoint string | ||
| target_currency string | ||
| } | ||
|
|
||
| func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { | ||
| bidder := &adapter{ | ||
| endpoint: config.Endpoint, | ||
| target_currency: "EUR", | ||
| } | ||
|
|
||
| return bidder, nil | ||
| } | ||
|
|
||
| func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) { | ||
| for i := range request.Imp { | ||
| imp := &request.Imp[i] | ||
| // Check if imp comes with bid floor amount defined in a foreign currency | ||
| if imp.BidFloor > 0 && imp.BidFloorCur != "" && strings.ToUpper(imp.BidFloorCur) != a.target_currency { | ||
|
|
||
| convertedValue, err := a.convertCurrency(imp.BidFloor, imp.BidFloorCur, reqInfo) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| imp.BidFloorCur = a.target_currency | ||
| imp.BidFloor = convertedValue | ||
| } | ||
| } | ||
|
|
||
| requestJSON, err := jsonutil.Marshal(request) | ||
| if err != nil { | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| requestData := &adapters.RequestData{ | ||
| Method: "POST", | ||
| Uri: a.endpoint, | ||
| Body: requestJSON, | ||
| ImpIDs: openrtb_ext.GetImpIDs(request.Imp), | ||
| } | ||
|
|
||
| return []*adapters.RequestData{requestData}, nil | ||
| } | ||
|
|
||
| func (a *adapter) convertCurrency(value float64, cur string, reqInfo *adapters.ExtraRequestInfo) (float64, []error) { | ||
| convertedValue, err := reqInfo.ConvertCurrency(value, cur, a.target_currency) | ||
|
|
||
| if err != nil { | ||
| var convErr currency.ConversionNotFoundError | ||
| if errors.As(err, &convErr) { | ||
|
|
||
| // try again by first converting to USD | ||
| // then convert to target_currency | ||
| convertedValue, err = reqInfo.ConvertCurrency(value, cur, "USD") | ||
|
|
||
| if err != nil { | ||
| return 0, []error{err} | ||
| } | ||
|
|
||
| convertedValue, err = reqInfo.ConvertCurrency(convertedValue, "USD", a.target_currency) | ||
|
|
||
| if err != nil { | ||
| return 0, []error{err} | ||
| } | ||
| } else { | ||
| return 0, []error{err} | ||
| } | ||
| } | ||
| return convertedValue, nil | ||
| } | ||
|
|
||
| func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.RequestData, responseData *adapters.ResponseData) (*adapters.BidderResponse, []error) { | ||
| if responseData.StatusCode == http.StatusNoContent { | ||
| return nil, nil | ||
| } | ||
|
|
||
| if responseData.StatusCode == http.StatusBadRequest { | ||
| err := &errortypes.BadInput{ | ||
| Message: "Unexpected status code: 400. Run with request.debug = 1 for more info.", | ||
| } | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| if responseData.StatusCode != http.StatusOK { | ||
| err := &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode), | ||
| } | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| var response openrtb2.BidResponse | ||
| if err := jsonutil.Unmarshal(responseData.Body, &response); err != nil { | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(request.Imp)) | ||
| bidResponse.Currency = response.Cur | ||
|
|
||
| var errs []error | ||
| for _, seatBid := range response.SeatBid { | ||
| for i, bid := range seatBid.Bid { | ||
| bidType, err := getBidType(bid.MType) | ||
| if err != nil { | ||
| errs = append(errs, err) | ||
| continue | ||
| } | ||
|
|
||
| bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{ | ||
| Bid: &seatBid.Bid[i], | ||
| BidType: bidType, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| return bidResponse, errs | ||
| } | ||
|
|
||
| func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) { | ||
| switch markupType { | ||
|
There was a problem hiding this comment. Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression. There was a problem hiding this comment. Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression. There was a problem hiding this comment. Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression. |
||
| case openrtb2.MarkupNative: | ||
| return openrtb_ext.BidTypeNative, nil | ||
| case openrtb2.MarkupBanner: | ||
| return openrtb_ext.BidTypeBanner, nil | ||
| default: | ||
| return "", &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unknown markup type: %d", markupType), | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package aduptech | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/prebid/prebid-server/v3/adapters/adapterstest" | ||
| "github.com/prebid/prebid-server/v3/config" | ||
| "github.com/prebid/prebid-server/v3/openrtb_ext" | ||
| ) | ||
|
|
||
| func TestJsonSamples(t *testing.T) { | ||
| bidder, buildErr := Builder(openrtb_ext.BidderAdUpTech, config.Adapter{ | ||
| Endpoint: "https://example.com/rtb/bid"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"}) | ||
|
|
||
| if buildErr != nil { | ||
| t.Fatalf("Builder returned unexpected error %v", buildErr) | ||
| } | ||
|
|
||
| adapterstest.RunJSONBidderTest(t, "aduptechtest", bidder) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| { | ||
| "mockBidRequest": { | ||
| "id": "test-request-id", | ||
| "site": { | ||
| "page": "https://good.site/url" | ||
| }, | ||
| "imp": [{ | ||
| "id": "test-imp-id", | ||
| "bidfloor": 1.0, | ||
| "bidfloorcur": "AUD", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 300, | ||
| "h": 250 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "publisher": "123456", | ||
| "placement": "234567" | ||
| } | ||
| } | ||
| }], | ||
| "ext": { | ||
| "prebid": { | ||
| "currency": { | ||
| "rates": { | ||
| "EUR": { | ||
| "USD": 0.05 | ||
| }, | ||
| "USD": { | ||
| "AUD": 2.0 | ||
| } | ||
| }, | ||
| "usepbsrates": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "httpCalls": [{ | ||
| "expectedRequest": { | ||
| "uri": "https://example.com/rtb/bid", | ||
| "body": { | ||
| "id": "test-request-id", | ||
| "site": { | ||
| "page": "https://good.site/url" | ||
| }, | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "bidfloor": 10, | ||
| "bidfloorcur": "EUR", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 250 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "publisher": "123456", | ||
| "placement": "234567" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "ext": { | ||
| "prebid": { | ||
| "currency": { | ||
| "rates": { | ||
| "EUR": { | ||
| "USD": 0.05 | ||
| }, | ||
| "USD": { | ||
| "AUD": 2.0 | ||
| } | ||
| }, | ||
| "usepbsrates": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "impIDs":["test-imp-id"] | ||
| }, | ||
| "mockResponse": { | ||
| "status": 200, | ||
| "body": { | ||
| "id": "test-request-id", | ||
| "seatbid": [ | ||
| { | ||
| "seat": "958", | ||
| "bid": [{ | ||
| "id": "7706636740145184841", | ||
| "impid": "test-imp-id", | ||
| "price": 0.500000, | ||
| "adm": "some-test-ad", | ||
| "adomain": ["example.com"], | ||
| "crid": "29681110", | ||
| "h": 250, | ||
| "w": 300, | ||
| "mtype": 1 | ||
| }] | ||
| } | ||
| ], | ||
| "cur": "EUR" | ||
| } | ||
| } | ||
| }], | ||
|
|
||
| "expectedBidResponses": [{ | ||
| "currency": "EUR", | ||
| "bids": [{ | ||
| "bid": { | ||
| "id": "7706636740145184841", | ||
| "impid": "test-imp-id", | ||
| "price": 0.500000, | ||
| "adm": "some-test-ad", | ||
| "adomain": ["example.com"], | ||
| "crid": "29681110", | ||
| "h": 250, | ||
| "w": 300, | ||
| "mtype": 1 | ||
| }, | ||
| "type": "banner" | ||
| }] | ||
| }] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.