Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PBSDK to add UID2 reference #5550

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Update PBSDK to add UID2 reference #5550

merged 4 commits into from
Sep 26, 2024

Conversation

bretg
Copy link
Contributor

@bretg bretg commented Aug 15, 2024

Resolves #5547

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 7e28eba
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66f181a2fef911000800c358
😎 Deploy Preview https://deploy-preview-5550--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

#### Unified ID (UID2)

- [Github repo](https://github.com/IABTechLab/uid2-ios-sdk)
- The app developer must manually obtain the UID2 token using the UID2 SDK, specifically UID2Manager.shared.getAdvertisingToken(). Please refer to [their documentation](https://unifiedid.com/docs/guides/integration-mobile-client-side#pass-generated-token-for-bidstream-use). Pass this value to Prebid Mobile SDK via setExternalUserIds() manually
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simhomer, @YuriyVelichkoPI - is "setExternalUserIds()" correct here? It's only mentioned once indirectly on this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publishers should use the Targeting.storeExternalUserId() method.

setExternalUserIds() is an internal SDK method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android: TargetingParams.storeExternalUserId()

@muuki88 muuki88 added the LGTM label Aug 20, 2024
@bretg
Copy link
Contributor Author

bretg commented Sep 17, 2024

Ok, sorry, but this is still not aligning for me. For the record, I was given this text to format into markdown, but it doesn't align with the UID2 documentation at https://unifiedid.com/docs/guides/integration-mobile-client-side#optional-uid2-prebid-mobile-sdk-integration

I need someone (maybe @YuriyVelichkoPI ?) to comment on what the prebid docs should say. There seems to be two main options:

  1. Describe the process in Prebid docs, including use of the storeExternalUserId() function. It should be in both iOS and Android docs.
  2. Just link to the UID2 docs. However, they don't currently mention storeExternalUserId() at all.

@bretg bretg removed the request for review from YuriyVelichkoPI September 26, 2024 17:34
@bretg bretg merged commit b8c5212 into master Sep 26, 2024
5 checks passed
@bretg bretg deleted the mobile-uid2 branch September 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Prebid Mobile SDK documentation to reference 3rd identity vendors
4 participants