Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Smoot #5619

Merged
merged 9 commits into from
Oct 11, 2024
Merged

New Adapter: Smoot #5619

merged 9 commits into from
Oct 11, 2024

Conversation

leamarty
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 6919f9c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6707d7cfc839fb0008268328
😎 Deploy Preview https://deploy-preview-5619--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dev-docs/bidders/smoot.md Outdated Show resolved Hide resolved
@leamarty leamarty requested a review from muuki88 October 3, 2024 15:25
@muuki88 muuki88 removed the needs work label Oct 3, 2024
@leamarty
Copy link
Contributor Author

leamarty commented Oct 7, 2024

This is in master already: prebid/Prebid.js#12268

Should this be merged?

@leamarty
Copy link
Contributor Author

leamarty commented Oct 9, 2024

Sorry for the push @muuki88 , I just want to make sure we'll make it to the next release (which I guess it's going to be soon)

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leamarty

No worries 😄 We merge docs only after they code has been released in prebid.js . A new prebid.js release will probably be built this week.

I haven't found any prebid server adapter and made suggestions you can just apply

dev-docs/bidders/smoot.md Outdated Show resolved Hide resolved
dev-docs/bidders/smoot.md Outdated Show resolved Hide resolved
@leamarty
Copy link
Contributor Author

@muuki88 thanks again for the review! My bad setting pbs support as "true". All corrected now!

@bretg
Copy link
Contributor

bretg commented Oct 11, 2024

release with 9.16

@bretg bretg merged commit 749ccfc into prebid:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants