fix and add test prefix to image so we can delete

predibase · Mar 11, 2024 · 29a9da0 · 29a9da0
1 parent 233208c
commit 29a9da0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -5,6 +5,7 @@ on:
   push:
     branches:
       - 'main'
+      - 'stream-log-dump' # XXX
     tags:
       - 'v*'
 
@@ -61,11 +62,12 @@ jobs:
         with:
           images: |
             ghcr.io/predibase/lorax
+          # XXX
           tags: |
-            type=semver,pattern={{version}}
-            type=semver,pattern={{major}}.{{minor}}
-            type=sha,prefix=,suffix=,format=short
-            type=raw,value=latest
+            type=sha,prefix=magdy-test-,suffix=,format=short
+            
+            
+
       
       - name: Create a hash from tags
         env:

diff --git a/router/src/server.rs b/router/src/server.rs
@@ -786,7 +786,7 @@ async fn metrics(prom_handle: Extension<PrometheusHandle>) -> String {
 
 async fn request_logger(mut rx: mpsc::Receiver<(i64, String, String)>) {
     let url = std::env::var("REQUEST_LOGGER_URL").ok();
-    if Some(&url) == None {
+    if url.is_none() {
         tracing::info!("REQUEST_LOGGER_URL not set, request logging is disabled");
         return;
     }
@@ -1016,7 +1016,7 @@ pub async fn run(
     let (tx, rx) = mpsc::channel(32);
     let request_logger_sender = Arc::new(tx);
     let url = std::env::var("REQUEST_LOGGER_URL").ok();
-    if Some(&url) != None {
+    if url.is_some() {
         tokio::spawn(request_logger(rx));
     } else {
         tracing::info!("REQUEST_LOGGER_URL not set, request logging is disabled");