start implementing cep 20 for abi3 packages #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
implement-cep20
branch
from
ceb9d29 to
3af62f4
Compare
|
@isuruf if you have time for a review, that would be highly appreciated! :) |
isuruf
reviewed
Jan 16, 2025
src/recipe/parser/build.rs
Outdated
Comment on lines
242
to
243
| if self.python().version_independent { | ||
| return NoArchType::python(); |
There was a problem hiding this comment.
Why do this?
In conda-build PR what I did was to check python_version_independent which was the union of python_version_independent setting and noarch: python setting.
wolfv
force-pushed
the
implement-cep20
branch
from
c525cbd to
8f29f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start to implement CEP 20 (following conda/conda-build#5456 and https://github.com/conda/ceps/blob/main/cep-0020.md)