Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvidia compiler support #1881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Nvidia compiler support #1881

wants to merge 2 commits into from

Conversation

abel0b
Copy link

@abel0b abel0b commented May 14, 2022

What does this PR do?

Add a new toolset module for Nvidia HPC C/C++ compiler (Closes #1874).

How does this PR change Premake's behavior?

No breaking change.

Anything else we should know?

I only tested that the new toolset can compile premake on my linux machine using gmake2 exporter.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016
Copy link
Member

nickclark2016 commented May 14, 2022

Closes #1874

@nickclark2016
Copy link
Member

I'll review this when I have time to sit down and read through the entire toolset. It's a wall of code, so it'll take me a while to get comfortable with it.

@abel0b
Copy link
Author

abel0b commented May 14, 2022

For information, a large part of the code is copied from the gcc toolset. I tried to find an equivalent in the Nvidia compiler for each flag but it's not always possible.

@nickclark2016
Copy link
Member

Sure, I don't expect equivalents to be there for everything. Do you mind posting a link to where you were referencing for the compiler flags just so I'm looking at the same sources as you when I review?

@abel0b
Copy link
Author

abel0b commented May 14, 2022

Here is the latest available documentation for nvidia compiler : NVIDIA HPC Compilers Reference Manual

@Jarod42
Copy link
Contributor

Jarod42 commented May 18, 2022

Should it be an external modules instead?

@nickclark2016
Copy link
Member

Should it be an external modules instead?

Definitely something worth considering.

@nickclark2016
Copy link
Member

Just poking the discussion on whether this should be an external module or a core module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nvidia compiler support
3 participants