-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nvidia compiler support #1881
base: master
Are you sure you want to change the base?
Nvidia compiler support #1881
Conversation
Closes #1874 |
I'll review this when I have time to sit down and read through the entire toolset. It's a wall of code, so it'll take me a while to get comfortable with it. |
For information, a large part of the code is copied from the gcc toolset. I tried to find an equivalent in the Nvidia compiler for each flag but it's not always possible. |
Sure, I don't expect equivalents to be there for everything. Do you mind posting a link to where you were referencing for the compiler flags just so I'm looking at the same sources as you when I review? |
Here is the latest available documentation for nvidia compiler : NVIDIA HPC Compilers Reference Manual |
Should it be an external modules instead? |
Definitely something worth considering. |
Just poking the discussion on whether this should be an external module or a core module. |
What does this PR do?
Add a new toolset module for Nvidia HPC C/C++ compiler (Closes #1874).
How does this PR change Premake's behavior?
No breaking change.
Anything else we should know?
I only tested that the new toolset can compile premake on my linux machine using gmake2 exporter.
Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!