Fix prelink step dependencies for gmake (to be done after compilation). #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
force-pushed
the
gmake_prelink
branch
from
f0eda51
to
ff7f91f
Compare
samsinsane
approved these changes
Aug 30, 2024
| @@ -248,7 +248,7 @@ | |||
|
|
|||
|
|
|||
| function make.preLinkRules(prj) | |||
| _p('prelink:') | |||
| _p('prelink: $(OBJECTS)') | |||
There was a problem hiding this comment.
Kinda weird that this didn't break any unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
prelinkstep for gmake generatorHow does this PR change Premake's behavior?
Just change gmake generator.
Anything else we should know?
Tested successfully on my testing repo: https://github.com/Jarod42/premake-sample-projects/actions/runs/4895539865
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)