Fix libzip missing a library #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of modifying source, can we use a forceinclude in the premake file? |
Sorry, I don't know how to include it in a premake file. If you know how to, feel free to modify so I can test it. |
|
This is something that's already in the premake file for the lib. You'd just need to update the filter to include linux instead of only MacOS. |
Now I understand. Thank you. |
SimplyCEO
force-pushed
the
libzip_fix
branch
from
5c25992
to
da607b8
Compare
|
Confirmed, compiled on both machines. |
|
No problem. I have an issue open to go in and update the library so we can get rid of the hack completely, just need to find time to do it. |
nickclark2016
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix premake compiling from undefined functions in libzip dependency.
Tested on
amd64:Tested on
armv7l: