Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use wildcard for buildinputs. #2150

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Oct 12, 2023

What does this PR do?

Allow to use wildcard for buildinputs.

i.e

buildinputs {"*.extra_inputs"}
-- instead of
-- buildinputs(os.matchfiles("*.extra_inputs"))

How does this PR change Premake's behavior?

Paths which have * now use wilcard instead of being passed as-is.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@nickclark2016
Copy link
Member

Are there any associated tests we can add for this?

@Jarod42
Copy link
Contributor Author

Jarod42 commented Oct 30, 2023

Each generators have some tests for buildinputs (but to test their rules, not wildcard). but I don't think it would be the right place to test each possible kind of value (wildcard, token, absolute path, relative path, ...).

There is missing (generic) tests\api\test_file_kind.lua but it would mostly to test api file than buildinputs.
I can add it.

@Jarod42
Copy link
Contributor Author

Jarod42 commented Oct 30, 2023

UTs for api added.

@nickclark2016 nickclark2016 merged commit fee075f into premake:master Oct 31, 2023
12 checks passed
@Jarod42 Jarod42 deleted the buildinputs_file branch October 31, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants