Enable code analysis via clang-tidy in Visual Studio #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thecomputekid <[email protected]>
6 tasks
Jarod42
reviewed
Feb 19, 2024
src/_premake_init.lua
Outdated
| @@ -169,6 +169,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| api.register { | |||
There was a problem hiding this comment.
As it seems visualstudio specific, put it in vstudio/_preload.lua instead.
Or maybe other generators "just" have to call clang-tidy source.cpp $(CXXFLAGS) after cxx source.cpp $(CXXFLAGS)...
There was a problem hiding this comment.
As it seems visualstudio specific, put it in vstudio/_preload.lua instead.
This suggestion is easier, and something I have now added a commit for. Perhaps clang-tidy for other generators can be future work.
Signed-off-by: thecomputekid <[email protected]>
samsinsane
approved these changes
Feb 27, 2024
6 tasks
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the selection of clang-tidy as a code analyser when the code analyser action of Visual Studio is run in the IDE. Further details can be found in the official documentation.
How does this PR change Premake's behavior?
Add configuration-scoped option
clangtidyfor Visual Studio 2019 and above.I have tried to follow pre-existing conventions:
compilebuildoutputsas an example.buildstlmodulesexample, which was a similar boolean.Did you check all the boxes?
Focus on a single fix or feature; remove any unrelated formatting or code changes
Add unit tests showing fix or feature works; all tests pass
Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
Follow our coding conventions
Minimize the number of commits
Align documentation to your changes