Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle buildaction "Copy" for gmake2. #2188

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Feb 19, 2024

What does this PR do?

Handle buildaction "Copy" for gmake2.

How does this PR change Premake's behavior?

Handle buildaction "Copy" for gmake2.

Anything else we should know?

Tested with https://github.com/Jarod42/premake-sample-projects/tree/master/projects/project-buildaction_copy
https://github.com/Jarod42/premake-sample-projects/actions/runs/7961205332/job/21731877841

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@Jarod42 Jarod42 marked this pull request as draft February 29, 2024 17:51
@Jarod42 Jarod42 marked this pull request as ready for review March 3, 2024 19:59
Copy link
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will leave it open for a few days in case others want to comment, then I'll merge (please feel free to ping me if I forget)

@nickclark2016 nickclark2016 merged commit af1c1b3 into premake:master Mar 8, 2024
12 checks passed
@Jarod42 Jarod42 deleted the gmake2_buildaction_copy branch March 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants