Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nested vsprops #2216

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

theComputeKid
Copy link
Contributor

@theComputeKid theComputeKid commented Jun 1, 2024

vsprops was added in #2112 with the following API:

vsprops {
  Name1 = "value1",
  Name2 = "value2",
}

This is a useful addition. However, nested properties are not allowed, and only one level of properties can be added to the project XML. This change enables nested properties. This is useful for custom tooling/extensions for Visual Studio.

This is not a breaking change for the original behaviour, it only adds nested vsprops:

vsprops {
  Name1 = "value1",
  Name2 = {
     Name3 = "value3"
  }
}

Translating to:

<Name1>Value1</Name1>
<Name2>
  <Name3>Value3</Name3>
</Name2>

While editing the file, I took the opportunity to remove unnecessary harmless extra spaces from a few lines in modules/vstudio/vs2010_vcxproj.lua, my IDE formatted them.

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@theComputeKid
Copy link
Contributor Author

@Jarod42 It has been quite some time, can this be merged pleased?

@Jarod42
Copy link
Contributor

Jarod42 commented Aug 2, 2024

@theComputeKid :I cannot merge, I don't have any rights on that repo. I'm like you, an external contributor...

@nickclark2016 nickclark2016 merged commit 9c9b6fc into premake:master Aug 2, 2024
14 checks passed
@theComputeKid theComputeKid deleted the nestedProps branch August 2, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants