Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a os.hostarch() function to get the host system architecture. #2251

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Sep 19, 2024

What does this PR do?

Add a os.hostarch() function to get the host system architecture.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@tritao
Copy link
Contributor Author

tritao commented Sep 19, 2024

Just realized host_arch does not follow the rest of the conventions, any preference between os.hostarch or os.hostArch as the name?

@samsinsane
Copy link
Member

Just realized host_arch does not follow the rest of the conventions, any preference between os.hostarch or os.hostArch as the name?

os.hostarch would be the preferred name.

@tritao tritao changed the title Add a os.host_arch() function to get the host system architecture. Add a os.hostarch() function to get the host system architecture. Sep 21, 2024
@tritao tritao marked this pull request as ready for review September 21, 2024 10:29
@tritao
Copy link
Contributor Author

tritao commented Sep 21, 2024

Updated the PR with fixed naming.

src/host/premake.c Outdated Show resolved Hide resolved
src/host/premake.h Show resolved Hide resolved
@tritao tritao force-pushed the os-host-arch branch 2 times, most recently from 3f974a6 to b9adb26 Compare September 21, 2024 11:42
@tritao
Copy link
Contributor Author

tritao commented Sep 25, 2024

@samsinsane This one should be ready to go, would be great if we can get this one merged since I'd like to send another one that builds on top of this.

@samsinsane samsinsane merged commit a5a00d6 into premake:master Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants