Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes data/ not being properly updated if a query update is null #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reimertz
Copy link

Description

Previously, when doing queries like below, if userId was removed from the invitees array, data was not properly updated. With this PR, data is properly updated.

firestoreConnect(props=> [{
      collection: 'events',
      populates,
      where: [
        ['invitees', 'array-contains', props.currentUser.uid],
      ],
      storeAs: 'events_invited'
    }]
)

Check List

If not relevant to pull request, check off as complete

  • [ x ] All tests passing
  • [ ? ] Docs updated with any changes or examples if applicable
  • [ ? ] Added tests to ensure new feature(s) work properly

@reimertz reimertz changed the title fixes data/ not being properly updated if a query result is updated w… fixes data/ not being properly updated if a query update is null Mar 25, 2019
@reimertz
Copy link
Author

On a second though, since I use storeAs, this might be the reason why nothing breaks when applying this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant