Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra space #453

Closed
wants to merge 1 commit into from
Closed

remove extra space #453

wants to merge 1 commit into from

Conversation

bkbncn
Copy link

@bkbncn bkbncn commented Jan 4, 2021

Hi, there is extra space for python and pyrex, but not for the other languages. We should fix the inconsistence.

@alerque
Copy link
Member

alerque commented Jan 6, 2021

I understand the inconsistency and appreciate the desire to clean it up, but unfortunately I don't think we can fix it this easily. We've actually tried before and had to revert it because it broke too many people's workflow without giving any easy way to fix them.

This has been discussed ad nauseum in other issues (see #202, #278, #328, #421), but the TL;DR version is that unlike most languages the space is actually part of the syntax and cannot be optional. NERDComenter doesn't have proper support for this, only for optional spaces. Until this is addressed properly we're left in kind of an awkward situation where there are only workarounds.

I'd be happy to accept a proper fix with per-language defaults for space handling, but this PR would just break the plugin for everybody who hasn't customized their config with a work-around.

@alerque alerque closed this Jan 6, 2021
@bkbncn bkbncn deleted the patch-1 branch January 6, 2021 21:03
@bkbncn
Copy link
Author

bkbncn commented Jan 6, 2021

All right, now I understand how come the inconsistence, and agree not everyone will customize this plugin, including me, I didn't customize before.

And my workaround about python is following, inspired by #202, hopefully help others.

let g:NERDSpaceDelims = 1
let g:NERDAltDelims_python = 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants