Trivial has_js patch #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mode with the has_js cookie. The approach here is not perfect as it assumes the site runs at the root of the host. This is possibly ok on a Pressflow install although not perfect. Drupal, in Javascript, sets the has_js cookie on / so it doesn't care about the true root either although / is slightly more glamorous. With this approach or a similar path based one the rest of the site URLs should be ok and cookie less. Thoughts?
|
I guess it could also be set in /admin for things like page manager to work a little nicer but I'll leave the very simple thing for now to see if this approach could work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember a merge proposal on launchpad to allow batch to work in JS mode with the has_js cookie. The approach here is not perfect as it assumes the site runs at the root of the host. This is possibly ok on a Pressflow install although not perfect. Drupal, in Javascript, sets the has_js cookie on / so it doesn't care about the true root either although / is slightly more glamorous.
With this approach or a similar path based one the rest of the site URLs should be ok and cookie less. Thoughts?