Menu rebuild lock_wait stampede #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A couple whitespace changes in there should be omitted. |
|
There are rare cases where the transaction will not be sufficient (e.g. the router or masks is empty), but I think those are rare enough to be worth trying this. |
| @@ -1697,25 +1697,25 @@ function menu_rebuild() { | |||
| // Wait for another request that is already doing this work. | |||
| // We choose to block here since otherwise the router item may not | |||
| // be avaiable in menu_execute_active_handler() resulting in a 404. | |||
| lock_wait('menu_rebuild'); | |||
There was a problem hiding this comment.
Should probably adjust the code comments too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock_wait() in menu_rebuild() is harmful. During a menu_rebuild, we observed processes on web servers stuck for 30 seconds due to the lock_wait.
Since Pressflow is using a transaction, it seems unnecessary to wait the process until it has completed.