Add Symfony 7.2 and PHP 8.4 to test matrix, add typing, fix deprecati…

…ons and remove superfluous docblock
prestaconcept · Dec 20, 2024 · 653f584 · 653f584
1 parent 62bf18a
commit 653f584
Show file tree

Hide file tree

Showing 9 changed files with 71 additions and 1 deletion.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -18,18 +18,26 @@ jobs:
     strategy:
       matrix:
         include:
-          - php-version: 7.2
+          - php-version: 7.4
             symfony-version: 5.4.*
           - php-version: 8.1
             symfony-version: 5.4.*
           - php-version: 8.1
             symfony-version: 6.4.*
           - php-version: 8.3
             symfony-version: 6.4.*
+          - php-version: 8.4
+            symfony-version: 6.4.*
           - php-version: 8.2
             symfony-version: 7.1.*
           - php-version: 8.3
             symfony-version: 7.1.*
+          - php-version: 8.4
+            symfony-version: 7.1.*
+          - php-version: 8.3
+            symfony-version: 7.2.*
+          - php-version: 8.4
+            symfony-version: 7.2.*
 
     steps:
       - name: "Checkout"

diff --git a/tests/Integration/config/7.2/framework.yaml b/tests/Integration/config/7.2/framework.yaml
@@ -0,0 +1,15 @@
+framework:
+    test: true
+    secret: '%env(APP_SECRET)%'
+    http_method_override: false
+    handle_all_throwables: true
+    session:
+        handler_id: null
+        cookie_secure: auto
+        cookie_samesite: lax
+        storage_factory_id: session.storage.factory.mock_file
+    php_errors:
+        log: true
+    router:
+        utf8: true
+    cache: null
diff --git a/tests/Integration/config/7.2/messenger.yaml b/tests/Integration/config/7.2/messenger.yaml
@@ -0,0 +1,6 @@
+framework:
+    messenger:
+        transports:
+            async: 'in-memory://'
+        routing:
+            'Presta\SitemapBundle\Messenger\DumpSitemapMessage': async
diff --git a/tests/Integration/config/7.2/presta_sitemap.yaml b/tests/Integration/config/7.2/presta_sitemap.yaml
@@ -0,0 +1,9 @@
+presta_sitemap:
+    default_section: static
+    dump_directory: "%kernel.project_dir%/public"
+    items_by_set: 10
+    alternate:
+        enabled: true
+        default_locale: en
+        locales: [en, fr]
+        i18n: symfony
diff --git a/tests/Integration/config/7.2/routes/controllers.yaml b/tests/Integration/config/7.2/routes/controllers.yaml
@@ -0,0 +1,3 @@
+controllers:
+    resource: ../../../src/Controller/
+    type: attribute
diff --git a/tests/Integration/config/7.2/routes/presta_sitemap.yaml b/tests/Integration/config/7.2/routes/presta_sitemap.yaml
@@ -0,0 +1,2 @@
+presta_sitemap:
+    resource: "@PrestaSitemapBundle/config/routing.yml"
diff --git a/tests/Integration/config/7.2/routes/translated.yaml b/tests/Integration/config/7.2/routes/translated.yaml
@@ -0,0 +1,7 @@
+about:
+  path:
+    en: /about
+    fr: /a-propos
+  defaults: { _controller: \Presta\SitemapBundle\Tests\Integration\Controller\StaticController::about }
+  options:
+    sitemap: true
diff --git a/tests/Integration/config/7.2/routes/xml.xml b/tests/Integration/config/7.2/routes/xml.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<routes xmlns="http://symfony.com/schema/routing"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://symfony.com/schema/routing http://symfony.com/schema/routing/routing-1.0.xsd">
+
+    <route id="xml" path="/company">
+        <default key="_controller">Presta\SitemapBundle\Tests\Integration\Controller\StaticController::company</default>
+        <option key="sitemap">
+            {"priority":"0.7", "changefreq":"weekly", "section":"static"}
+        </option>
+    </route>
+
+</routes>
diff --git a/tests/Integration/config/7.2/routes/yaml.yaml b/tests/Integration/config/7.2/routes/yaml.yaml
@@ -0,0 +1,6 @@
+yaml:
+  path: /contact
+  defaults: { _controller: \Presta\SitemapBundle\Tests\Integration\Controller\StaticController::contact }
+  options:
+    sitemap:
+      section: static
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		presta_sitemap:
		resource: "@PrestaSitemapBundle/config/routing.yml"