Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation around generating absolute URLs with Symfony #336

Merged
merged 1 commit into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions doc/2-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ you have to set the base URL of where you sitemap files will be accessible. The
of the URL will also be used to make Router generate URLs with hostname.

```yaml
# config/services.yaml
parameters:
router.request_context.host: your-domain.com
router.request_context.scheme: http
# config/packages/routing.yaml
framework:
router:
default_uri: 'https://your-domain.com'
```

> **Note:** You may noticed that there is nothing specific to this bundle.
> **Note:** You may have noticed that there is nothing specific to this bundle.
> In fact, doing this you just allowed your whole application to generate URLs from the command line.
> Please have a look to Symfony's [official documentation](https://symfony.com/doc/current/console/request_context.html)
> Please have a look to Symfony's [official documentation](https://symfony.com/doc/current/routing.html#generating-urls-in-commands)
> for more information.


Expand Down
2 changes: 1 addition & 1 deletion src/Command/DumpSitemapsCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ protected function configure(): void
null,
InputOption::VALUE_REQUIRED,
'Base url to use for absolute urls. Good example - http://acme.com/, bad example - acme.com.' .
' Defaults to router.request_context.host parameter'
' Defaults to Symfony\'s default routing context'
)
->addOption(
'gzip',
Expand Down
Loading