Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stream_get_meta_data uri is always defined #347

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

yann-eugone
Copy link
Member

OK... Now that I fixed PhpStan error in #345

 ------ ---------------------------------------------------------------------- 
  Line   Sitemap/DumpingUrlset.php                                             
 ------ ---------------------------------------------------------------------- 
  62     Offset 'uri' does not exist on array{timed_out: bool, blocked: bool,  
         eof: bool, unread_bytes: int, stream_type: string, wrapper_type:      
         string, wrapper_data: mixed, mode: string, ...}.                      
 ------ ---------------------------------------------------------------------- 

And now that we are running tests on PHP 8.3, we have the opposite error

 ------ ---------------------------------------------------------------------- 
  Line   Sitemap/DumpingUrlset.php                                             
 ------ ---------------------------------------------------------------------- 
  61     Offset 'uri' on array{timed_out: bool, blocked: bool, eof: bool,      
         unread_bytes: int, stream_type: string, wrapper_type: string,         
         wrapper_data: mixed, mode: string, ...} in isset() always exists and  
         is not nullable.                                                      
 ------ ---------------------------------------------------------------------- 

I decided to just ignore this error, because this is no big deal, and it really depends on the PHP version, and we are not even close to only support PHP >= 8.3

@yann-eugone yann-eugone requested a review from J-Ben87 June 11, 2024 07:54
@yann-eugone yann-eugone merged commit 62bf18a into 4.x Jun 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants