[native] Refactor Duration::toString and DataSize::toString to use fm…

…t::format
prestodb · Dec 20, 2024 · 0377f99 · 0377f99
1 parent 004ee32
commit 0377f99
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/presto-native-execution/presto_cpp/presto_protocol/core/DataSize.cpp b/presto-native-execution/presto_cpp/presto_protocol/core/DataSize.cpp
@@ -12,6 +12,7 @@
  * limitations under the License.
  */
 #include "presto_cpp/presto_protocol/core/DataSize.h"
+#include <fmt/format.h>
 #include <math.h>
 
 namespace facebook::presto::protocol {
@@ -29,16 +30,12 @@ DataSize::DataSize(const std::string& string) {
 }
 
 std::string DataSize::toString() const {
-  char buffer[32];
-  snprintf(
-      buffer,
-      sizeof(buffer),
-      "%f%s",
+  return fmt::format(
+      "{:f}{}",
       round(value_ * 100.0) / 100.0,
-      dataUnitToString(dataUnit_).c_str());
-  return std::string(buffer);
+      dataUnitToString(dataUnit_)
+  );
 }
-
 double DataSize::toBytesPerDataUnit(DataUnit dataUnit) {
   switch (dataUnit) {
     case DataUnit::BYTE:

diff --git a/presto-native-execution/presto_cpp/presto_protocol/core/Duration.cpp b/presto-native-execution/presto_cpp/presto_protocol/core/Duration.cpp
@@ -12,6 +12,7 @@
  * limitations under the License.
  */
 #include "presto_cpp/presto_protocol/core/Duration.h"
+#include <fmt/format.h>
 
 namespace facebook::presto::protocol {
 
@@ -27,14 +28,11 @@ Duration::Duration(const std::string& duration) {
 }
 
 std::string Duration::toString() const {
-  char buffer[32];
-  snprintf(
-      buffer,
-      sizeof(buffer),
-      "%.2f%s",
+  return fmt::format(
+      "{:.2f}{}",
       value_,
-      timeUnitToString(timeUnit_).c_str());
-  return std::string(buffer);
+      timeUnitToString(timeUnit_)
+  );
 }
 
 double Duration::toMillisPerTimeUnit(TimeUnit timeUnit) {