-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Support for Iceberg table sort orders
- Loading branch information
Showing
34 changed files
with
1,235 additions
and
86 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
presto-hive/src/main/java/com/facebook/presto/hive/SortingFileWriterConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.facebook.presto.hive; | ||
|
|
||
| import com.facebook.airlift.configuration.Config; | ||
| import com.facebook.airlift.configuration.ConfigDescription; | ||
| import io.airlift.units.DataSize; | ||
| import io.airlift.units.MaxDataSize; | ||
| import io.airlift.units.MinDataSize; | ||
|
|
||
| import javax.validation.constraints.Max; | ||
| import javax.validation.constraints.Min; | ||
|
|
||
| import static io.airlift.units.DataSize.Unit.MEGABYTE; | ||
|
|
||
| public class SortingFileWriterConfig | ||
| { | ||
| private DataSize writerSortBufferSize = new DataSize(64, MEGABYTE); | ||
| private int maxOpenSortFiles = 50; | ||
|
|
||
| @MinDataSize("1MB") | ||
| @MaxDataSize("1GB") | ||
| public DataSize getWriterSortBufferSize() | ||
| { | ||
| return writerSortBufferSize; | ||
| } | ||
|
|
||
| @Config("writer-sort-buffer-size") | ||
| @ConfigDescription("Defines how much memory is used for this in-memory sorting process.") | ||
| public SortingFileWriterConfig setWriterSortBufferSize(DataSize writerSortBufferSize) | ||
| { | ||
| this.writerSortBufferSize = writerSortBufferSize; | ||
| return this; | ||
| } | ||
|
|
||
| @Min(2) | ||
| @Max(1000) | ||
| public int getMaxOpenSortFiles() | ||
| { | ||
| return maxOpenSortFiles; | ||
| } | ||
|
|
||
| @Config("max-open-sort-files") | ||
| @ConfigDescription("When writing, the maximum number of temporary files opened at one time to write sorted data.") | ||
| public SortingFileWriterConfig setMaxOpenSortFiles(int maxOpenSortFiles) | ||
| { | ||
| this.maxOpenSortFiles = maxOpenSortFiles; | ||
| return this; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
presto-hive/src/test/java/com/facebook/presto/hive/TestSortingFileWriterConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.hive; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import io.airlift.units.DataSize; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import static com.facebook.airlift.configuration.testing.ConfigAssertions.assertFullMapping; | ||
| import static com.facebook.airlift.configuration.testing.ConfigAssertions.assertRecordedDefaults; | ||
| import static com.facebook.airlift.configuration.testing.ConfigAssertions.recordDefaults; | ||
| import static io.airlift.units.DataSize.Unit.GIGABYTE; | ||
| import static io.airlift.units.DataSize.Unit.MEGABYTE; | ||
|
|
||
| public class TestSortingFileWriterConfig | ||
| { | ||
| @Test | ||
| public void testDefaults() | ||
| { | ||
| assertRecordedDefaults(recordDefaults(SortingFileWriterConfig.class) | ||
| .setWriterSortBufferSize(new DataSize(64, MEGABYTE)) | ||
| .setMaxOpenSortFiles(50)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testExplicitPropertyMappings() | ||
| { | ||
| Map<String, String> properties = ImmutableMap.<String, String>builder() | ||
| .put("writer-sort-buffer-size", "1GB") | ||
| .put("max-open-sort-files", "3") | ||
| .build(); | ||
| SortingFileWriterConfig expected = new SortingFileWriterConfig() | ||
| .setWriterSortBufferSize(new DataSize(1, GIGABYTE)) | ||
| .setMaxOpenSortFiles(3); | ||
| assertFullMapping(properties, expected); | ||
| } | ||
| } |
Oops, something went wrong.