Fix failing tests

- failing equality delete test - typo in assertion on test update with predicate
prestodb · Dec 19, 2024 · e56fc7c · e56fc7c
1 parent e61ff60
commit e56fc7c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...berg/src/main/java/com/facebook/presto/iceberg/optimizer/IcebergEqualityDeleteAsJoin.java b/...berg/src/main/java/com/facebook/presto/iceberg/optimizer/IcebergEqualityDeleteAsJoin.java
@@ -331,7 +331,7 @@ private TableScanNode createDeletesTableScan(ImmutableMap<VariableReferenceExpre
                     icebergTableHandle.isSnapshotSpecified(),
                     icebergTableHandle.getOutputPath(),
                     icebergTableHandle.getStorageProperties(),
-                    Optional.of(SchemaParser.toJson(new Schema(deleteFields))),
+                    icebergTableHandle.getTableSchemaJson(),
                     icebergTableHandle.getPartitionSpecJson(),
                     Optional.of(deleteInfo.partitionFields.keySet()),                // Enforce reading only delete files that match this schema
                     Optional.ofNullable(deleteInfo.equalityFieldIds.isEmpty() ? null : deleteInfo.equalityFieldIds),

diff --git a/presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java b/presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
@@ -2274,8 +2274,8 @@ public void testUpdateWithPredicates()
         assertQuery("SELECT id, full_name, email FROM " + tableName, "VALUES (1, 'aaaa', '[email protected]'), (2, 'ssss', '[email protected]'), (3, 'ssss', '[email protected]'), (4, 'dddd', '[email protected]') ");
 
         // set values to null
-        assertUpdate("UPDATE " + tableName + " SET email = NULL", 1);
-        assertQuery("SELECT email FROM " + tableName + "WHERE email is NULL", "VALUES NULL");
+        assertUpdate("UPDATE " + tableName + " SET email = NULL", 4);
+        assertQuery("SELECT email FROM " + tableName + " WHERE email is NULL", "VALUES NULL");
 
         // update nulls to non-null
         assertUpdate("UPDATE " + tableName + " SET email = '[email protected]' WHERE full_name is NULL", 1);