Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of getTypeLength() #23618

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Fix deprecation of getTypeLength() #23618

merged 1 commit into from
Sep 29, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Sep 10, 2024

Description

getTypeLength() --> getPrimitiveType().getTypeLength() (Inline method)

Motivation and Context

get ready for eventual parquet upgrade

Impact

none

Test Plan

mvn test

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo changed the title Fix deprecation in getTypeLength() Fix deprecation of getTypeLength() Sep 10, 2024
@elharo elharo marked this pull request as ready for review September 11, 2024 17:03
@elharo elharo requested review from shangxinli and a team as code owners September 11, 2024 17:03
@tdcmeehan
Copy link
Contributor

Please fix up the commit so it conforms to our guidelines. Perhaps Remove use of deprecated getTypeLength method.

@tdcmeehan tdcmeehan self-assigned this Sep 27, 2024
@elharo
Copy link
Contributor Author

elharo commented Sep 27, 2024

done

@elharo elharo merged commit bd07a0e into master Sep 29, 2024
56 checks passed
@elharo elharo deleted the depre2 branch September 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants