[Do Not Review] Set splitsize for hadoop InputFormat to Presto max_split_size #23635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any way to add a test case for this? |
elharo
reviewed
Sep 12, 2024
| @@ -93,6 +94,7 @@ | |||
| import static java.lang.Math.max; | |||
| import static java.lang.String.format; | |||
| import static java.util.Objects.requireNonNull; | |||
| import static org.apache.hadoop.mapreduce.lib.input.FileInputFormat.SPLIT_MINSIZE; | |||
There was a problem hiding this comment.
This feels like a large dependency to add just for a constant string. Consider using the literal value instead.
|
Sure, I will check on how we can add a test for this. |
agrawalreetika
force-pushed
the
config-split-size
branch
2 times, most recently
from
c81d8f7
to
ebb04e8
Compare
Currently added tests are mainly checking how split generation is affected if we use the Hadoop library directly. |
agrawalreetika
force-pushed
the
config-split-size
branch
3 times, most recently
from
79e6452
to
a7bc015
Compare
elharo
previously approved these changes
Sep 24, 2024
agrawalreetika
force-pushed
the
config-split-size
branch
7 times, most recently
from
02acbb6
to
9f646e1
Compare
agrawalreetika
changed the title
agrawalreetika
force-pushed
the
config-split-size
branch
9 times, most recently
from
19bef1c
to
22dc0d8
Compare
agrawalreetika
force-pushed
the
config-split-size
branch
from
22dc0d8
to
530dba4
Compare
agrawalreetika
force-pushed
the
config-split-size
branch
from
530dba4
to
2334207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set splitsize for hadoop InputFormat to Presto max_split_size
Details in #23608
Motivation and Context
Make splitsize configurable where hadoop InputForma library is used for split generation.
Resolves #23608
Impact
Make splitsize configurable where hadoop InputForma library is used for split generation.
Resolves #23608
Test Plan
Contributor checklist
Release Notes