Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to enable eager building of plan as part of new native plan checker SPI #23649

Merged

Commits on Oct 9, 2024

  1. Add property for eager building of plan

    As part of new native plan checker SPI, the new property
    eager-plan-validation-enabled will enable the eager building and
    validation of a logical plan so that any errors or incompatibilities
    in the plan will cause the query to fail quickly, before queueing
    and cluster resources are assigned to keep queries with invalid
    plans from holding slots in the queue.
    
    RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0008-plan-checker.md
    BryanCutler committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5e0f3fe View commit details
    Browse the repository at this point in the history
  2. Add SPI to support plugin for custom plan checkers

    This adds a new SPI to support plugin custom plan checkers to be
    provided for validating intermediate, final, and fragment stages of
    a logical plan. The motivation for this is to allow for a native plan
    checker that will eagerly validate a plan on the native sidecar to
    quickly fail the query if there are incompatibilities.
    
    Add unit test to verify that a queued query can be validated
    and fail while queued. This is done by using the new custom
    plan checker SPI to add plugin that will trigger a failure when
    validating the plan.
    
    See also: prestodb#23596
    RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0008-plan-checker.md
    BryanCutler committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3d1961e View commit details
    Browse the repository at this point in the history