Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presto-native-tests module #23671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pramodsatya
Copy link
Contributor

@pramodsatya pramodsatya commented Sep 18, 2024

Description

Adds module presto-native-tests to run end-to-end tests with Presto native workers.

Motivation and Context

Improves Presto native test coverage by extending production tests from presto-tests module to use the native worker.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== RELEASE NOTES ==

General Changes
* Add presto-native-tests module :pr:`23671`

steveburnett
steveburnett previously approved these changes Sep 18, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Reviewed README.md, no concerns. Thanks for the doc!

@tdcmeehan
Copy link
Contributor

Are these tests being run as part of the CI?

@pramodsatya
Copy link
Contributor Author

They are not being run as part of CI currently, but we plan to setup a pipeline to run these tests on a regular cadence subsequently. Will also add a CI job to run these tests in a follow-up PR.

public class TestAggregations
extends AbstractTestAggregationsNative
{
private static final String storageFormat = "PARQUET";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just testing parquet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the intention was to primarily test with parquet files. Most of the current e2e tests in presto-native-execution test with DWRF format. We can extend this to test with other file formats going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants