Disassemble more dungeon functions #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonymousRandomPerson
requested changes
Oct 23, 2024
|
I looked into the JP mismatch, and it's because we aren't yet sure where the dungeon struct differs between JP and other regions. Here's a commit you can use to match JP for now: AnonymousRandomPerson@0ef94e7 |
|
Thanks! That helps a lot! I'll keep in mind that we might need to move those ifdefs around in the future, and have updated my pre-pr build to build all languages. |
|
Build is failing because of Wine not downloading properly, possibly due to mirrors being out of sync. This happens on occasion and should resolve itself in a while. |
AnonymousRandomPerson
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.