Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify and correct usage of breakable whitespace characters #1094

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Clarify and correct usage of breakable whitespace characters #1094

merged 9 commits into from
Nov 20, 2023

Commits on Nov 6, 2023

  1. Clarify description of breakable spaces

    @SnorlaxMonster
    SnorlaxMonster committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e011e7e View commit details
    Browse the repository at this point in the history

  2. Correct comments that quote Japanese move text 

    Comments that quote what the equivalent Japanese text is when using
certain moves were incorrect. I have adjusted these comments to quote
the correct text, based on Japanese Pokémon Crystal.
    @SnorlaxMonster
    SnorlaxMonster committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b85e341 View commit details
    Browse the repository at this point in the history

  3. Correct control characters in Japanese strings 

    Use the Japanese control character for $1f instead of the English
control character in untranslated Japanese strings in mobile data.
    @SnorlaxMonster
    SnorlaxMonster committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    2105783 View commit details
    Browse the repository at this point in the history

  4. Replace ¯ and % with more meaningful names 

    Replace the two breakable whitespace characters ($1f and $25)
with meaningful angle-bracketed names, instead of using arbitrary
symbols.
    @SnorlaxMonster
    SnorlaxMonster committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    238989a View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Apply suggestions from code review 

    Rename <ZWSP> to <WBR> to match HTML element name
Simplify comments explaining breakable whitespace characters

Co-authored-by: Rangi <[email protected]>
    @SnorlaxMonster @Rangi42
    SnorlaxMonster and Rangi42 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    772c5f4 View commit details
    Browse the repository at this point in the history

  2. Add old $1f and $25 charmaps to legacy.asm

    @SnorlaxMonster
    SnorlaxMonster committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    92fe9fa View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @Rangi42
    Rangi42 authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    94a1a8b View commit details
    Browse the repository at this point in the history

  4. Update legacy.asm

    @Rangi42
    Rangi42 authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e04789f View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge remote-tracking branch 'origin/master' into text

    @SnorlaxMonster
    SnorlaxMonster committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    4bb408a View commit details
    Browse the repository at this point in the history