Add defintion for OAM y-Coordinate offscreen value #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd honestly rather a new constant for this, the math isn't really obvious (OAM_YCOORD_DISABLED or similar, please think of a better name than this) |
Why come up with a better name when you have a perfectly terrible name right here. LOL I'll think of something soon. |
|
|
vulcandth
force-pushed
the
fix-y-coord-def
branch
from
3eaabb1
to
c88f3b5
Compare
vulcandth
changed the title
vulcandth
added a commit
to pret/pokegold
that referenced
this pull request
Apr 14, 2024
vulcandth
added a commit
to pret/pokegold
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://gbdev.io/pandocs/OAM.html#byte-0--y-position
Essentially, a y-coord of 160 is the screen's height (144) plus the height of a 8x16 sprite (2 tiles).