Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Unown wall word data #1131

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Refactor the Unown wall word data #1131

merged 1 commit into from
Jul 24, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Jul 21, 2024

No description provided.

@Rangi42 Rangi42 requested a review from vulcandth July 21, 2024 14:53
vulcandth
vulcandth approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@vulcandth vulcandth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than taking note of my comment, everything else looks good!

engine/events/unown_walls.asm Outdated Show resolved Hide resolved
@Rangi42 Rangi42 merged commit fed587f into pret:master Jul 24, 2024
1 check passed
@Rangi42 Rangi42 deleted the unown branch July 24, 2024 14:56
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@Rangi42
Refactor the Unown wall word data (#1131)
aa5bddf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

@vulcandth vulcandth vulcandth approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rangi42 @vulcandth @ISSOtm