Correct Moon Ball bug documentation #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Moon Ball both uses the wrong item ID and checks the wrong memory address. Modify the proposed patch to also correct the memory address that the Moon Ball checks.
|
Yes, thanks for proposing this patch and explaining the issue. That is correct. As you were saying, I've checked how the Moon Ball works and found that it looks for the item in the wrong memory address in the manner you described. I tried testing this in some different ways, such as editing how some specific Pokémon evolve or changing how the Moon Ball works. To perform those tests, I've only used a hex editor so far. I haven't tried compiling or editing the pret code. For the record, the Moon Ball works that way in Gold/Silver/Crystal in all languages, including English, Japanese and (GS) Korean. |
Rangi42
reviewed
Oct 17, 2024
Rangi42
reviewed
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bugs and Glitches documentation currently says that the Moon Ball fails to boost the catch rate of Pokémon that evolve via Moon Stone because the Gen 1 item ID for the Moon Stone, which now points to the Burn Heal, was used. However, recent research by DanielCM has shown that this is not the only issue, and fixing only that issue will not fix the Moon Ball.
The Moon Ball is also checking the wrong memory address for the item that triggers evolution. Specifically, after confirming that the Pokémon evolves by item, it advances 3 bytes (2 bytes past the ID of the evolution item). The byte it checks is the evolution list terminator (0x00) for Pokémon with only one evolution, and the evolution method of the Pokémon's second evolution for Pokémon with multiple evolution branches. There is no evolution method with ID 0x0A, so this condition can still never be met.
The updated proposed patch still only checks the first evolution method, but that is sufficient to correctly identify all Pokémon in the game that evolve via Moon Stone.