New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exported constants for VC patch #1161

Merged

Rangi42 merged 5 commits into pret:master from vulcandth:VC-use-exported-constants

Dec 27, 2024

Collaborator

vulcandth commented Dec 26, 2024

No description provided.

vulcandth force-pushed the VC-use-exported-constants branch from e03af7c to 9659bd1 Compare

December 26, 2024 03:31

Rangi42 requested changes

View reviewed changes

constants/gfx_constants.asm Outdated Show resolved Hide resolved

tools/make_patch.c Outdated Show resolved Hide resolved

vulcandth force-pushed the VC-use-exported-constants branch from 9659bd1 to 9f5a3d8 Compare

December 26, 2024 03:46

Rangi42 reviewed

View reviewed changes

docs/vc_patch.md Show resolved Hide resolved

Rangi42 reviewed

View reviewed changes

tools/make_patch.c Outdated Show resolved Hide resolved

Rangi42 reviewed

View reviewed changes

tools/make_patch.c Outdated Show resolved Hide resolved

Rangi42 reviewed

View reviewed changes

tools/make_patch.c Outdated Show resolved Hide resolved

Rangi42 reviewed

View reviewed changes

tools/make_patch.c Outdated Show resolved Hide resolved

Rangi42 reviewed

View reviewed changes

tools/make_patch.c Outdated Show resolved Hide resolved


          Use exported constants for VC patch

d31ed08

vulcandth force-pushed the VC-use-exported-constants branch from a6fac5f to d31ed08 Compare

December 26, 2024 21:08

This was referenced Dec 26, 2024

Use exported constants for VC patch pret/pokered#483

Merged

Use exported constants for VC patch pret/pokeyellow#124

Merged

Use exported constants for VC patch pret/pokegold#125

Merged

Rangi42 reviewed

View reviewed changes

docs/vc_patch.md Outdated Show resolved Hide resolved


          Update docs/vc_patch.md

e1497b9

Rangi42 reviewed

View reviewed changes

includes.asm Show resolved Hide resolved


          Update includes.asm

87eadf7

Rangi42 approved these changes

View reviewed changes

Member

Rangi42 left a comment

Thanks for addressing my comments! I made one more change to only include the vc constants asm file when building the VC ROM. Now it should be ready to base the other three repos' PRs on.

Rangi42 requested changes

View reviewed changes

docs/vc_patch.md Outdated Show resolved Hide resolved

tools/make_patch.c Outdated Show resolved Hide resolved

Rangi42 added 2 commits

December 27, 2024 13:08


          Update docs/vc_patch.md

59a267d


          Update tools/make_patch.c

e1864e3

Rangi42 approved these changes

View reviewed changes

Rangi42 merged commit 0124a1e into pret:master

1 check passed

Rangi42 deleted the VC-use-exported-constants branch

December 27, 2024 18:10

github-actions bot pushed a commit that referenced this pull request


          Use exported constants for VC patch (#1161)

946d72f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet