Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pokecrystal using hardware.inc #943

Closed
wants to merge 55 commits into from
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
bec5db7
pokecrystal using hardware.inc
rawr51919 Jun 14, 2022
146ac7d
Finish the rest of the constants I forgot
rawr51919 Jun 15, 2022
a5a6163
Update audio/engine.asm
rawr51919 Jun 15, 2022
81c2b40
Add comments for changed constants
rawr51919 Jun 15, 2022
01f7188
hardware.inc now in the repo directly
rawr51919 Jun 15, 2022
70cacee
Implement all suggestions as best I can
rawr51919 Jun 15, 2022
a7558c7
Remove some duplicates from extra_hardware_constants.asm
rawr51919 Jun 15, 2022
3707036
Remove unused constants from extra_hardware_constants.asm
rawr51919 Jun 15, 2022
c6e6382
fix a small booboo
rawr51919 Jun 15, 2022
5fb97c7
use numbers instead of letters for wave pattern loading
rawr51919 Jun 15, 2022
fc5265d
remove hardware.inc include, not needed
rawr51919 Jun 15, 2022
8b9f04a
Fix incorrect constant
ISSOtm Jun 16, 2022
14b392d
Turn `1 << *B_*` into `*F_*` for convenience
ISSOtm Jun 16, 2022
c9fe20c
Remove superfluous parens
ISSOtm Jun 16, 2022
719bfb0
Merge pull request #1 from ISSOtm/hardware.inc-gbdev
rawr51919 Jun 16, 2022
a76c6de
Add comment for old constant name
rawr51919 Jun 16, 2022
10c242d
Finish the last of the hardware.inc conversion
rawr51919 Jun 16, 2022
46a3f96
Fix a minor character booboo
rawr51919 Jun 16, 2022
d5a0abc
Add comments for a constant yet to be added
rawr51919 Jun 16, 2022
5e4d5f1
Revise previous commit to fix matching
rawr51919 Jun 16, 2022
0cd8949
Derped up the bitwise shifting
rawr51919 Jun 16, 2022
a4cd29d
Rereadd rNR20 and rNR40 as audio constants
rawr51919 Jun 16, 2022
1846403
We've reached a compromise on these two pesky constants!
rawr51919 Jun 17, 2022
941eecd
Rebase and fix merge conflicts
rawr51919 Jun 18, 2022
cfc283d
Merge branch 'pret:master' into hardware.inc-gbdev
rawr51919 Jun 19, 2022
9b00116
Merge branch 'pret:master' into hardware.inc-gbdev
rawr51919 Jun 21, 2022
8a1dddc
Update engine/link/link.asm
rawr51919 Jun 25, 2022
b4d2398
Update engine/link/link.asm
rawr51919 Jun 25, 2022
38560f1
Update engine/link/link.asm
rawr51919 Jun 25, 2022
e360996
Update engine/link/link.asm
rawr51919 Jun 25, 2022
601c7f9
Update home/serial.asm
rawr51919 Jun 25, 2022
9592c15
Update home/serial.asm
rawr51919 Jun 25, 2022
19aa322
Update home/serial.asm
rawr51919 Jun 25, 2022
fb78a64
Update home/serial.asm
rawr51919 Jun 25, 2022
9913651
Update lib/mobile/main.asm
rawr51919 Jun 25, 2022
c5f225c
Update engine/link/link.asm
rawr51919 Jun 25, 2022
d950f64
Update engine/link/link.asm
rawr51919 Jun 26, 2022
dd77c3b
Update engine/link/link.asm
rawr51919 Jun 26, 2022
8e898e6
Update engine/link/link.asm
rawr51919 Jun 26, 2022
2aa1495
Update engine/link/link.asm
rawr51919 Jun 26, 2022
6a3b0b9
Update engine/link/link.asm
rawr51919 Jun 26, 2022
9376ca8
Update engine/link/link.asm
rawr51919 Jun 26, 2022
ed78c0a
Update engine/link/link.asm
rawr51919 Jun 26, 2022
6716eb9
Update engine/link/link.asm
rawr51919 Jun 26, 2022
86f19eb
Update engine/link/mystery_gift.asm
rawr51919 Jun 26, 2022
9bdc67a
Update engine/link/mystery_gift.asm
rawr51919 Jun 26, 2022
11e73d2
Update engine/link/mystery_gift.asm
rawr51919 Jun 26, 2022
9569587
Update engine/printer/printer.asm
rawr51919 Jun 26, 2022
9b86a93
Update engine/printer/printer_serial.asm
rawr51919 Jun 26, 2022
4b36536
Update engine/printer/printer_serial.asm
rawr51919 Jun 26, 2022
3b891fe
Merge branch 'pret:master' into hardware.inc-gbdev
rawr51919 Jun 26, 2022
d150253
Merge branch 'master' of https://github.com/coltongit/pokecrystal int…
rawr51919 Jun 26, 2022
bb66ae6
Apply suggestions from code review
rawr51919 Jun 26, 2022
ac90ae6
Merge branch 'hardware.inc-gbdev' of https://github.com/coltongit/pok…
rawr51919 Jun 26, 2022
99749c3
Add RPB_DATAIN and fix comment
rawr51919 Jun 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions audio/engine.asm
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ UpdateChannels:
ldh a, [rNR52]
and %10001101 ; ch2 off
ldh [rNR52], a
ld hl, rNR20
ld hl, $ff15 ; rNR20 (imaginary)
rawr51919 marked this conversation as resolved.
Show resolved Hide resolved
call ClearChannel
ret

Expand Down Expand Up @@ -434,37 +434,37 @@ endr
add hl, de
; load wavepattern into rWave_0-rWave_f
ld a, [hli]
ldh [rWave_0], a
ldh [_AUD3WAVERAM], a ; rWave_0
ld a, [hli]
ldh [rWave_1], a
ldh [$ff31], a ; rWave_1
rawr51919 marked this conversation as resolved.
Show resolved Hide resolved
ld a, [hli]
ldh [rWave_2], a
ldh [$ff32], a ; rWave_2
ld a, [hli]
ldh [rWave_3], a
ldh [$ff33], a ; rWave_3
ld a, [hli]
ldh [rWave_4], a
ldh [$ff34], a ; rWave_4
ld a, [hli]
ldh [rWave_5], a
ldh [$ff35], a ; rWave_5
ld a, [hli]
ldh [rWave_6], a
ldh [$ff36], a ; rWave_6
ld a, [hli]
ldh [rWave_7], a
ldh [$ff37], a ; rWave_7
ld a, [hli]
ldh [rWave_8], a
ldh [$ff38], a ; rWave_8
ld a, [hli]
ldh [rWave_9], a
ldh [$ff39], a ; rWave_9
ld a, [hli]
ldh [rWave_a], a
ldh [$ff3a], a ; rWave_a
ld a, [hli]
ldh [rWave_b], a
ldh [$ff3b], a ; rWave_b
ld a, [hli]
ldh [rWave_c], a
ldh [$ff3c], a ; rWave_c
ld a, [hli]
ldh [rWave_d], a
ldh [$ff3d], a ; rWave_d
ld a, [hli]
ldh [rWave_e], a
ldh [$ff3e], a ; rWave_e
ld a, [hli]
ldh [rWave_f], a
ldh [$ff3f], a ; rWave_f
pop hl
ld a, [wCurTrackVolumeEnvelope]
and $f0
Expand All @@ -491,7 +491,7 @@ endr
ldh a, [rNR52]
and %10000111 ; ch4 off
ldh [rNR52], a
ld hl, rNR40
ld hl, $ff1f ; rNR40 (imaginary)
call ClearChannel
ret

Expand Down
2 changes: 1 addition & 1 deletion constants.asm
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ INCLUDE "charmap.asm"

INCLUDE "macros.asm"

INCLUDE "constants/hardware_constants.asm"
INCLUDE "constants/hardware.inc"
INCLUDE "constants/deco_constants.asm"
INCLUDE "constants/wram_constants.asm"
INCLUDE "constants/misc_constants.asm"
Expand Down
Loading