synchronise bg_window.c with heartgold #523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I genuinely hate graphics programming, this is the worst part of the rom, even with all the shit I've seen and everything that doesn't make sense, this fucking file is the worst out of all of them. I genuinely hate this shit, it's actually frustrating, sometimes the bg id is a u32 and sometimes it's a u8, the enum doesn't work if it's a u8, and some parts don't match, and some parts don't match if everything is a u32, I don't get why they didn't just put it fully as one or the other, I once again question the mental capacity of the people who wrote this file in the first place, and question whether they were on drugs or having drunk some serious alcohol for this, because this shit makes barely any sense, there's shit in here which you would expect to find in gen 2, and not on a graphics system like the DS, like actually, you'd think they'd be past this by now, but of course not, since this is GF code here. This is not made any better by the fucking compiler, which only does what you'd expect half the fucking time, and the other half of the time needs a weird hack or just straight up won't work, I've had to explicitly cast to u8 a few times because that gets the compiler to work, even if the original variable is of u8, I am genuinely starting to be convinced that metrowerks, freescale, nintendo, and game freak all got together and threw a massive drug party that lasted a few months and designed and programmed the games, libraries, tools, and compilers used in it
I still have a bunch to do here, but I'm only so masochistic, and every single second I take another look at this file I am losing braincells, I need them to continue to push these roms forward, because we only have a few contributors who are working on gen 4.